 |
Java开发网 |
|
注册 |
登录 |
帮助 |
搜索 |
排行榜 |
发帖统计
|
| 您没有登录 |
» Java开发网 » Java EE 综合讨论区
 打印话题
寄给朋友
订阅主题
|
    
|
| 作者 | Re:SQLExecutor : A Simple Open-Source JDBC Framework (TheServerSide) [Re:why] |
floater
Java Jedi 总版主 
发贴: 3233 积分: 421 
|
 于 2003-09-12 05:31
    
user-related: 1. Connection pool should be an interface, not a concrete class, so we could plug in other implementations, e.g., DataSource/JNDI lookup. 2. This implementation of Connection pool assumes we can create as many connections as we want - if none is available, creat a new one. So this is not in a production quality. implementation-related 1. It would be better that SQLResults is also an interface, to shield out what users get and what package creator needs to populate; it would be easier to maintain it too, e.g., performance improvement later on, we just change the class, not the interface. 2. Transaction can be implemented in a seperate class to avoid complexity. 3. A better pool can be implemented using BoundedBuffer in Doug Lee's util.concurrent package. 4. Move all implementations to subdirectories could have a cleaner view of the src tree. So overall, this one is really close except the connection pool. "Any fool can write code that a computer can understand. Good programmers write code that humans can understand." - Martin Fowler, Refactoring - Improving the Design of Existing Code |
| 话题树型展开 |
|
|
已读帖子 新的帖子 被删除的帖子 |
|
 |
Powered by Jute Powerful Forum® Version Jute 1.5.6 Ent Copyright © 2002-2021 Cjsdn Team. All Righits Reserved. 闽ICP备05005120号-1 客服电话 18559299278 客服信箱 714923@qq.com 客服QQ 714923 |