刚刚接手了这样一个servlet代码,看完差点没吐血而亡!!!
public void service(HttpServletRequest httpservletrequest,
HttpServletResponse httpservletresponse) throws
ServletException, IOException {
.......//some code init httpservletrequest
try {
ObjectInputStream objectinputstream = new ObjectInputStream(
httpservletrequest.getInputStream());
int i = objectinputstream.readInt();//read command
switch ( i ) {
case 1: // '\001'
method1(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 2: // '\002'
method2(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 3: // '\002'
method3(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 4: // '\004'
method4(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 5: // '\005'
method5(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 6: // '\006'
method6(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 7: // '\007'
method7(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 8: // '\007'
method8(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 9: // '\007'
method9(httpservletrequest, httpservletresponse, objectinputstream);
break;
case 10: // '\007'
method10(httpservletrequest, httpservletresponse, objectinputstream);
break;
case -1:
postvalue(httpservletrequest, httpservletresponse, objectinputstream);
break;
case -2:
postFolderInfo(httpservletrequest, httpservletresponse,objectinputstream);
break;
}
}
catch (Exception exception) {
exception.printStackTrace();
}
finally {
}
真不敢相信这是一段出自软件公司程序员之手的代码!!!
我认为即便是有任何特殊原因,也不应该编写这样的代码。
这段代码根本没有OOP观念不说,连最基本的编码规范都不懂!
从这段代码来看,其作者简直是个门外汉!
“Any fool can write code that a computer can understand. Good programmers write code that humans can understand.”-------现在我对这句话有了更深刻的了解............